Remove 3h compatibility code #3069
Conversation
Signed-off-by: linning <[email protected]>
Signed-off-by: linning <[email protected]>
Signed-off-by: linning <[email protected]>
Signed-off-by: linning <[email protected]>
Signed-off-by: linning <[email protected]>
Signed-off-by: linning <[email protected]>
crates/pallet-domains/src/staking.rs
Outdated
| @@ -191,8 +191,7 @@ pub struct Operator<Balance, Share, DomainBlockNumber> { | |||
| /// The status of the operator, it may be stale due to the `OperatorStatus::PendingSlash` is | |||
| /// not assigned to this field directly, thus MUST use the `status()` method to query the status | |||
| /// instead. | |||
| /// TODO: update the filed to `_status` to avoid accidental access in next network reset | |||
| status: OperatorStatus<DomainBlockNumber>, | |||
| _status: OperatorStatus<DomainBlockNumber>, | |||
There was a problem hiding this comment.
Maybe the name should be something else entirely? _ has the purpose of not triggering unused field lints. Not sure why it needs to be renamed if it is hidden in the first place.
There was a problem hiding this comment.
I was trying to emphasize this field should not be queried directly. Yeah, perhaps the comment and private field would be enough, I will rename it back to status or it would be great if you have other suggestions.
There was a problem hiding this comment.
I was thinking something like partial_status or preliminary_status or something similar, what makes sense in this context
There was a problem hiding this comment.
Thanks! renamed to partial_status.
Signed-off-by: linning <[email protected]>
|
Test hang on Linux:
https://github.com/autonomys/subspace/actions/runs/11055943073/job/30716305690?pr=3069#step:12:1811 Since this PR modifies domains code, I'm going to re-run the tests, but disable automatic merging until we've checked that it isn't making the tests fail more often. |
Seems fine, I've re-run the tests again to be sure, and re-enabled auto merge. |
close #2936
This PR finishes all the remaining items in #2936.
Code contributor checklist: